Update communicator.go #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming convention consistencies.
|
|
||
| // On windows, filepath.Dir uses backslash separators (ie. "\tmp"). | ||
| // This does not work when the target host is unix. Switch to forward slash | ||
| // which works for unix and windows | ||
| target_dir = filepath.ToSlash(target_dir) | ||
| targeDir = filepath.ToSlash(targeDir) |
There was a problem hiding this comment.
Do you mind setting this to targetDir, I think you forgot a t :)
There was a problem hiding this comment.
Yes. Sorry. These were done in github's code browser so typos are all too easy.
|
Just one comment but LGTM after that. |
|
Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming convention consistencies.